-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify l2 withdrawals root in live sync #14583
Comments
this is planned but this requires a lot of work. for this feature I think we can get away with integrating this into the but I believe an easier integration would be in the payloadvalidator for now reth/crates/optimism/payload/src/builder.rs Lines 403 to 418 in c5df8fb
the state root stuff is super messy rn (working on it). |
this new method for verifying against hashed storage fits better into reth/crates/consensus/consensus/src/lib.rs Lines 30 to 45 in faa55d9
|
Describe the feature
Verify isthmus withdrawals root with consensus rules implemented in #14308 either before, or optimistically after, this statement.
reth/crates/engine/tree/src/tree/mod.rs
Line 2551 in c9a348d
Pros of doing before is early bail if l2 withdrawals root doesn't verify and skip hashing all state updates (just the state updates for the predeploy account, if any).
To do this we either need to surface the
EngineApiTreeHandler
to sdk level, or some hack with adding a trait methodFullConsensus::validate_block_post_execution_live_sync_only
wdyt @mattsse @klkvr
Additional context
No response
The text was updated successfully, but these errors were encountered: