Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove optimism feature from chainspec crate #9450

Closed
Tracked by #7576
mattsse opened this issue Jul 11, 2024 · 2 comments
Closed
Tracked by #7576

remove optimism feature from chainspec crate #9450

mattsse opened this issue Jul 11, 2024 · 2 comments
Assignees
@loocapro
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started S-blocked This cannot more forward until something else changes S-duplicate This issue or PR already exists

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jul 11, 2024

Describe the feature

blocked by #9439

once we have separate binaries we can now also get rid of the optimism features we have in chainspec crate.

the duplicated is_optimism function can be removed because not called by eth stuff anymore.
and DEV spec can be duplicated to OP_DEV and regular DEV

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started S-blocked This cannot more forward until something else changes labels Jul 11, 2024
@mattsse mattsse mentioned this issue Jul 11, 2024
Closed
@loocapro
Copy link
Contributor

May I?

@emhane
Copy link
Member

emhane commented Aug 22, 2024

duplicate of #8904

@emhane emhane closed this as completed Aug 22, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Aug 22, 2024
@emhane emhane added the S-duplicate This issue or PR already exists label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@loocapro loocapro

Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started S-blocked This cannot more forward until something else changes S-duplicate This issue or PR already exists
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@loocapro @mattsse @emhane