Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle inserting disconnected blocks gracefully #9935

Closed
Tracked by #8742
mattsse opened this issue Jul 31, 2024 · 0 comments
Closed
Tracked by #8742

Handle inserting disconnected blocks gracefully #9935

mattsse opened this issue Jul 31, 2024 · 0 comments
Assignees

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jul 31, 2024

We may receive a (partially) disconnected block as new payload or when we download it.

this block can't be executed and would currently result in a BlockHashNotFound error if we don't have the last block in that chain:

let historical = self.provider.state_by_block_hash(parent_hash)?;

TODO

  • handle this case gracefully and buffer the block if it's a new payload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant