Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly handle recursive types #133

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix: properly handle recursive types #133

merged 1 commit into from
Nov 20, 2024

Conversation

DaniPopes
Copy link
Member

Fixes #129

@DaniPopes DaniPopes requested a review from onbjerg as a code owner November 19, 2024 21:22
@DaniPopes DaniPopes force-pushed the dani/recursive-types branch from 259306f to feb2cce Compare November 19, 2024 21:22
onbjerg
onbjerg approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall

crates/data-structures/src/cycle.rs Outdated Show resolved Hide resolved
@DaniPopes DaniPopes force-pushed the dani/recursive-types branch from feb2cce to 8d34939 Compare November 20, 2024 12:05
@DaniPopes DaniPopes enabled auto-merge (squash) November 20, 2024 12:07
@DaniPopes DaniPopes force-pushed the dani/recursive-types branch from 8d34939 to 1998777 Compare November 20, 2024 12:07
@DaniPopes DaniPopes merged commit fc5d2d2 into main Nov 20, 2024
12 checks passed
@DaniPopes DaniPopes deleted the dani/recursive-types branch November 20, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ICE]: nested struct with two members as return value for an interface function
2 participants
@DaniPopes @onbjerg