Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate functions with no visibility specified #160

Merged
merged 11 commits into from
Dec 10, 2024

Conversation

TilakMaddy
Copy link
Contributor

@TilakMaddy TilakMaddy commented Dec 8, 2024

Validate the functions where no visibility has been specified and suggest help message.

@TilakMaddy TilakMaddy closed this Dec 8, 2024
@TilakMaddy TilakMaddy changed the title feat: function visibility check for non free functions [Need Help] feat: function visibility check for contract functions [Need Help] Dec 9, 2024
@TilakMaddy
Copy link
Contributor Author

@DaniPopes any suggestion you might have for me here ?

@DaniPopes DaniPopes reopened this Dec 9, 2024
crates/sema/src/ast_passes.rs Outdated Show resolved Hide resolved
crates/sema/src/ast_passes.rs Outdated Show resolved Hide resolved
crates/sema/src/ast_passes.rs Outdated Show resolved Hide resolved
@TilakMaddy TilakMaddy force-pushed the feat/ast-validations-p3 branch from 9328e15 to af1d07f Compare December 10, 2024 06:12
@TilakMaddy TilakMaddy force-pushed the feat/ast-validations-p3 branch from 142b054 to 084d06c Compare December 10, 2024 06:32
@TilakMaddy TilakMaddy marked this pull request as ready for review December 10, 2024 06:53
@TilakMaddy TilakMaddy requested a review from onbjerg as a code owner December 10, 2024 06:53
@TilakMaddy TilakMaddy changed the title feat: function visibility check for contract functions [Need Help] feat: function visibility check for contract functions Dec 10, 2024
@TilakMaddy TilakMaddy changed the title feat: function visibility check for contract functions feat: validate functions with no visibility specified Dec 10, 2024
@TilakMaddy TilakMaddy requested a review from DaniPopes December 10, 2024 17:35
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crates/sema/src/ast_passes.rs Outdated Show resolved Hide resolved
@TilakMaddy TilakMaddy requested a review from DaniPopes December 10, 2024 18:23
@DaniPopes DaniPopes merged commit 48dfff6 into paradigmxyz:main Dec 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants