-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: validate functions with no visibility specified #160
Merged
DaniPopes
merged 11 commits into
paradigmxyz:main
from
TilakMaddy:feat/ast-validations-p3
Dec 10, 2024
Merged
feat: validate functions with no visibility specified #160
DaniPopes
merged 11 commits into
paradigmxyz:main
from
TilakMaddy:feat/ast-validations-p3
Dec 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TilakMaddy
commented
Dec 8, 2024
TilakMaddy
changed the title
feat: function visibility check for non free functions [Need Help]
feat: function visibility check for contract functions [Need Help]
Dec 9, 2024
@DaniPopes any suggestion you might have for me here ? |
DaniPopes
reviewed
Dec 9, 2024
DaniPopes
reviewed
Dec 9, 2024
TilakMaddy
force-pushed
the
feat/ast-validations-p3
branch
from
December 10, 2024 06:12
9328e15
to
af1d07f
Compare
TilakMaddy
force-pushed
the
feat/ast-validations-p3
branch
from
December 10, 2024 06:32
142b054
to
084d06c
Compare
TilakMaddy
changed the title
feat: function visibility check for contract functions [Need Help]
feat: function visibility check for contract functions
Dec 10, 2024
TilakMaddy
changed the title
feat: function visibility check for contract functions
feat: validate functions with no visibility specified
Dec 10, 2024
DaniPopes
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: DaniPopes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate the functions where no visibility has been specified and suggest help message.