feat: underscores and literals validation #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
reviewed
Dec 11, 2024
crates/sema/src/ast_passes.rs
Outdated
Comment on lines
316
to
324
| // Intentionally override unused default implementations to reduce bloat. | ||
| fn visit_expr(&mut self, _expr: &'ast ast::Expr<'ast>) -> ControlFlow<Self::BreakValue> { | ||
| let ast::Expr { kind, .. } = _expr; | ||
| if let ast::ExprKind::Lit(lit, _) = kind { | ||
| self.check_underscores_in_number_literals(lit); | ||
| } | ||
| ControlFlow::Continue(()) | ||
| } | ||
|
|
There was a problem hiding this comment.
Now this also has to recurse into other expressions and types, so remove the comment, the visit_ty implementation, and add walk_expr at the end
TilakMaddy
commented
Dec 12, 2024
Comment on lines
+11
to
+12
| uint256 g = 1_.4e10 + 3.4e_10; //~ERROR: invalid use of underscores in number literal | ||
| //~^ERROR: invalid use of underscores in number literal |
There was a problem hiding this comment.
I've added this to prove that expression recursion works for this error message
DaniPopes
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ethereum/solidity/blob/df01dcc7b759f53ba45811979d3286562eab7846/libsolidity/analysis/SyntaxChecker.cpp#L288C1-L322C14