Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networking probably uses ROFI_UNREACHABLE in the wrong way #250

Open
Ondraceq opened this issue Oct 26, 2022 · 0 comments
Open

networking probably uses ROFI_UNREACHABLE in the wrong way #250

Ondraceq opened this issue Oct 26, 2022 · 0 comments

Comments

@Ondraceq
Copy link
Contributor

From discussion in #241

Probably should use something more like trap and assume.
Also there is a question why use a function that is not virtual and can never be called (because calling ROFI_UNREACHABLE invokes undefined behaviour and does NOT abort the program) - it is probably better to pass a nullptr to the place where you want to pass this function (at least in release mode).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ondraceq