Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplesim: Handle disconnects #277

Open
jajik opened this issue Dec 9, 2022 · 1 comment
Open

simplesim: Handle disconnects #277

jajik opened this issue Dec 9, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@jajik
Copy link
Contributor

jajik commented Dec 9, 2022

When a connected configuration is loaded into the simplesim, and then it disconnects, forming two separate components, the simplesim terminates with SIGABRT if the positions of both parts are not fixed.

The simplesim should not terminate, but it should inform the user about the missing fixation. Optionally, it could fix the second part's position to that it had before the disconnect, as that is usually what the user wants (however, additional issues arise with this approach).

@jajik jajik added the bug Something isn't working label Dec 9, 2022
@Ondraceq
Copy link
Contributor

I believe the second solution is something we shouldn't do - since it seems like something that the user would want, but we would strengthen the believe that nothing can happen if the user separates the rofibot in two and the tries to join them inside a reconfiguration algorithm - which should 100% be avoided.

Yes, it shouldn't abort - but this is a larger thing that should be fixed - it's not only when disconnecting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants