Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace fixed resource names with unique to release name #49

Open
akshay196 opened this issue Aug 8, 2022 · 0 comments
Open

Replace fixed resource names with unique to release name #49

akshay196 opened this issue Aug 8, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@akshay196
Copy link
Member

Describe the issue you're facing

Hard-coding the name: into a resource is usually considered to be bad practice. Names should be unique to a release. Fixed name can cause the naming conflict if more than one instance of Paralus are deployed to a same namespace.

Create a helper function to generate unique name similar to this. And use that in place of hard coded name.

metadata:
  name: {{ include "ztka.fullname" . }}-dashboard
@akshay196 akshay196 added the new Needs triage label Aug 8, 2022
@meain meain added enhancement New feature or request good first issue Good for newcomers and removed new Needs triage labels Aug 8, 2022
@akshay196 akshay196 added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Mar 30, 2023
@akshay196 akshay196 self-assigned this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

2 participants