Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move kratos-automigrate under kratos init-containers #83

Open
niravparikh05 opened this issue Mar 31, 2023 · 1 comment
Open

Move kratos-automigrate under kratos init-containers #83

niravparikh05 opened this issue Mar 31, 2023 · 1 comment
Labels
enhancement New feature or request triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@niravparikh05
Copy link
Contributor

Describe the issue you're facing

  • While upgrading kratos helm chart which will be defaulted to the corresponding app version cause issue with health probe if the migration is run on a different / lower version.

Currently kratos-automigrate is present as part of paralus init container and kratos binary is packaged with it ( now if there is a mismatch between kratos app version here and one helm chart uses, health probe fails to bring kratos pod up ), explore the possibility of moving it as kratos init container to avoid this dependency

@niravparikh05 niravparikh05 added new Needs triage needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 31, 2023
@akshay196 akshay196 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed new Needs triage needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 1, 2023
@akshay196
Copy link
Member

Backstory: Kratos-automigrate is part of paralus init container because paralus db-migration is dependent on kratos tables. Parlaus db-migration fails unless kratos migration is successfully completed.

Few rough ideas to resolve this issue:

  1. Remove kratos and paralus migration coupling. This might be a right step for project maintainability because it decouples Kratos and Paralus migrations.
  2. Let paralus init container decide kratos migration based on kratos version in use. This can be accomplished using a simple bash-script that reads kratos version, download respective binary and perform migration.

@akshay196 akshay196 added the enhancement New feature or request label Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

2 participants