do not create namespaces if it does not exist #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niravparikh05
requested review from
venukrishna,
avinashpenmetsa,
meain and
akshay196
meain
reviewed
Jul 15, 2022
| @@ -6,6 +6,7 @@ All notable changes to this project will be documented in this file. | |||
| ### Added | |||
| ### Changed | |||
| ### Fixed | |||
| - Don't automatically create namespace if it does not exist ([#28](https://github.com/paralus/relay/issues/28)) | |||
There was a problem hiding this comment.
The format would be:
Suggested change
| - Don't automatically create namespace if it does not exist ([#28](https://github.com/paralus/relay/issues/28)) | |
| - Don't automatically create namespace if it does not exist from [niravparikh05](https://github.com/niravparikh05) |
|
This change introduces a side effect. Whenever admin enters a namespace that does not exist in target cluster, relay fails to create role / rolebinding and ends up with multiple requests throttling kube api server. Further analysis needs to be done to fix this before it can be merged, |
|
Closing this stale pr, will be reprioritized and will open a new pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Does the PR depend on any other PRs or Issues? If yes, please list them.
Checklist
I confirm, that I have...
CONTRIBUTING.mdgo fmt(if applicable)CHANGELOG.md