Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parinfer Parens Mode bug #187

Closed
NightMachinery opened this issue May 5, 2018 · 5 comments
Closed

Parinfer Parens Mode bug #187

NightMachinery opened this issue May 5, 2018 · 5 comments

Comments

@NightMachinery
Copy link

-               ("map" . 8614           ; ↦
-                (push pretty-symbol prettify-symbols-alist))))))
+               ("map" . 8614)           ; ↦
+               )) (push pretty-symbol prettify-symbols-alist)))

The - parts are parinfer's doing. You can take a look at the complete diff log I posted at syl20bnr/spacemacs#10648 . Another prominent example is that parinfer moves comments out of sexps:

   (lispyville-set-key-theme
    '(operators
      c-w
-     (escape insert)))
-  ;; (additional-movement normal visual motion)
-  
+     (escape insert)
+     ;; (additional-movement normal visual motion)
+     ))
@shaunlebron
Copy link
Collaborator

thanks! Can you paste your file into this page below to see if it's really a problem with core, or just the spacemacs plugin?

https://beta.observablehq.com/@shaunlebron/parinfer-test

@colonelrascals
Copy link
Contributor

@shaunlebron @NightMachinary I've run both examples through the parinfer test, and it does seem that parenMode moves comments out of sexps.

Screen shot is attached.

parenmode

@colonelrascals
Copy link
Contributor

Possibly ignore closing the paren until the comment is escaped?

@shaunlebron
Copy link
Collaborator

Right, this is the major issue tracked in #92, and have been slumbering on implementation in #175

P.S. Observable ❤️ 💯

@shaunlebron
Copy link
Collaborator

Closing as a duplicate of #92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants