Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use namespace feature to avoid prefixed dependencies with jsonrpsee-. #776

Open
lexnv opened this issue May 20, 2022 · 4 comments
Open

Use namespace feature to avoid prefixed dependencies with jsonrpsee-. #776

lexnv opened this issue May 20, 2022 · 4 comments
Labels
good first issue Good for newcomers

Comments

@lexnv
Copy link
Contributor

lexnv commented May 20, 2022

Namespace features are stabilized as of: rust-lang/cargo#5565.

This would remove the prefixed dependencies and some duplicate lines.

Blocked by: dhovart/cargo-local-registry#170

@lexnv lexnv added the good first issue Good for newcomers label May 20, 2022
@niklasad1 niklasad1 added this to the Future milestone Jun 23, 2022
@jsdw jsdw removed this from the v1.1 milestone Feb 20, 2023
@NTP-996
Copy link

NTP-996 commented Dec 29, 2023

I would like to work on this issue, please

@niklasad1
Copy link
Member

Go ahead, let us know if you need any additional help

@NTP-996
Copy link

NTP-996 commented Dec 29, 2023

@niklasad1 Is there any specific way to contribute? I haven't found the contribution guideline. I can start by forking the repo and creating a branch with the same name as this issue. And then create the PR, Is that ok for you guys?

@niklasad1
Copy link
Member

niklasad1 commented Dec 29, 2023

Yes, forking and creating a PR is perfect.

I guess fixing this issue will be quite small but in general don't make huge changes such renaming lots
of files, formatting and so on before getting feedback from us because it's increases the likelihood of getting rejected.

Let's create another issue for a contribution guide then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants