Implement NoProof for json tests and update tests reference #9744

cheme · 2018-10-12T17:55:32Z

Closes #9590 .

Update to latest ethereum/tests .
Fix cost for constantinople test json.
Implements 'NoProof' engine from ethereum/tests#464 .

At this point with this PR everything pass except the case spotted by /cc @holiman this week in https://gist.github.com/holiman/0154f00d5fcec5f89e85894cbb46fcb2 .

I skip those tests. For completeness, @sorpaas indicated that it is not an easy fix : so since those case cannot happen on a mainchain I did not open and reference an issue for them (in the json defining tests to skip I only added a comment but not issue reference).

Note for reviewer:

when running NoProof with CanonNoSeal, the upper gas limit verification is required : I switch it from verify_block_basic to the header check. I got to put another trait method for it, a lighter change would be to make this check for every engine but it would change a bit the existing behavior (might not be an issue).

Block test are really not working so I disabled a few by commenting directly in source.

Since tests has been regenerated those one were failing on block difficulty check. Update ethereum/tests, waiting for cost fix (block test are still commented).

identified case). Fix block reward of constantinople json.

parity-cla-bot · 2018-10-12T17:55:36Z

It looks like this contributor signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

sorpaas · 2018-10-13T01:03:36Z

ethcore/src/json_tests/chain.rs

+		}
+
+		/// No nonce handle, skip test.
+		fn verify_block_unordered(&self, _header: &Header) -> Result<(), Error> {


What's the difference of this and VerifierType::CanonNoSeal? It looks like here in addition we skipped verify_block_unordered transaction basics verification, which I worry would give us some true negatives of failing tests.

Yes 'check_seal' false will probably do it, I'll check that on monday, on ice till then.

additional tests code.

5chdn · 2018-10-15T18:14:44Z

we need to backport this, don't we?

verification, the test is running in `verify_header_param`. Note that test was previously only for ethash, and now for any engine.

sorpaas · 2018-10-16T09:27:32Z

A little bit confused on this:

some test were pointing to old json, I simply copied the old version of the test, that may not be the best solution but it keeps things unchanged.

Why do we need to point to old json files for those tests?

cost of an additional trait method.

cheme · 2018-10-16T11:40:24Z

@sorpaas I just fix it properly, basically no handling of NoProof for one and change of querried blocks for the other.

@5chdn it could be good to backport, just to be able to run latest json-tests suite.

* prevent zero networkID, closes openethereum#8345 Signed-off-by: Seun LanLege <[email protected]> * updated networkID of olymic chain spec Signed-off-by: Seun LanLege <[email protected]>

* docs: add changelog for parity ethereum v2.1.3 beta * docs: add changelog for parity ethereum v2.0.7 stable

sorpaas

LGTM! Just a few grumbles on <whitespace>/<tab>.

sorpaas · 2018-10-16T14:07:06Z

ethcore/res/ethereum/tests-issues/currents.json

-				"CreateOOGafterInitCodeReturndata2_d0g1v0_Constantinople"
-			]
+			"reference": "None",
+      "comment": "This failing test is deemed skippable. Could not happen on a mainnet.",


tabify this line

sorpaas · 2018-10-16T14:07:12Z

ethcore/res/ethereum/tests-issues/currents.json

-				"push32withoutByte_d0g0v0_Constantinople"
-			]
+			"reference": "None",
+      "comment": "This failing test is deemed skippable. Could not happen on a mainnet.",


tabify this line

sorpaas · 2018-10-16T14:07:22Z

ethcore/res/ethereum/tests-issues/currents.json

-		{
-			"reference": "9590",
+			"reference": "None",
+      "comment": "This failing test is deemed skippable. Could not happen on a mainnet.",


tabify this line

sorpaas · 2018-10-16T14:07:28Z

ethcore/res/ethereum/tests-issues/currents.json

-		{
-			"reference": "9590",
+			"reference": "None",
+      "comment": "This failing test is deemed skippable. Could not happen on a mainnet.",


tabify this line

Update tests submodule to latest master (lot of new sstore tests passing)

* Expose config max-round-blocks-to-import * Fix test

* removed "rustup" & added new runner tag * exchanged tag "rust-windows" with "windows" * revert windows tag change

* Update Dockerfile Since parity is built for "mission critical use", I thought other operators may see the need for this. Adding the `curl` and `jq` commands allows for an extremely simple health check to be usable in container orchestrators. For example. Here is a health check for a parity docker container running in Kubernetes. This can be setup as a readiness Probe that would prevent clustered nodes that aren't ready from serving traffic. ```bash #!/bin/bash ETH_SYNCING=$(curl -X POST --data '{"jsonrpc":"2.0","method":"eth_syncing","params":[],"id":1}' http://localhost:8545 -H 'Content-Type: application/json') RESULT=$(echo "$ETH_SYNCING | jq -r .result) if [ "$RESULT" == "false" ]; then echo "Parity is ready to start accepting traffic" exit 0 else echo "Parity is still syncing the blockchain" exit 1 fi ``` * add sync check script

Block test are really not working so I disabled a few by commenting directly in source.

Since tests has been regenerated those one were failing on block difficulty check. Update ethereum/tests, waiting for cost fix (block test are still commented).

identified case). Fix block reward of constantinople json.

additional tests code.

verification, the test is running in `verify_header_param`. Note that test was previously only for ethash, and now for any engine.

cost of an additional trait method.

Update tests submodule to latest master (lot of new sstore tests passing)

synch).

…eum into ethereum_tests_update

This reverts commit b82d0b0.

cheme · 2018-10-26T13:29:00Z

I close this request (I really messed up my rebase), #9814 replaces this.

…9744) (#9814) * Update test reference. Block test are really not working so I disabled a few by commenting directly in source. * Move ethtest commit cursor. * Implements 'NoProof' engine from ethereum/tests#464 . Since tests has been regenerated those one were failing on block difficulty check. Update ethereum/tests, waiting for cost fix (block test are still commented). * Update tests submodule reference to latest (all test passing except an identified case). Fix block reward of constantinople json. * Restore broken test by using old json tests files. * Use CanonNoSeal instead of a custom engine, still have to include some additional tests code. * Gas upper limit check in json_chain test was bad, moving the test to verification, the test is running in `verify_header_param`. Note that test was previously only for ethash, and now for any engine. * Restore old behavior (gas uper limit only for ethash engine), at the cost of an additional trait method. * Proper rpc test fix. * Update tests submodule, add SStore bug tests. * Fix json issue tabulation. Update tests submodule to latest master (lot of new sstore tests passing) * Switch ethereum/tests to tag 6.0.0-beta.1 (no tests changes from latest synch). * Display hex with separator, use indirection instead of clone for copy types.

* version: mark 2.2.0 beta * ci: remove failing tests for android, windows, and macos (#9788) * ci: remove failing tests for android, windows, and macos * ci: restore android build jobs * Move state root verification before gas used (#9841) * Classic.json Bootnode Update (#9828) * fix: Update bootnodes list to only responsive nodes * feat: Add more bootnodes to classic.json list * feat: Add retested bootnodes * Implement NoProof for json tests and update tests reference (replaces #9744) (#9814) * Update test reference. Block test are really not working so I disabled a few by commenting directly in source. * Move ethtest commit cursor. * Implements 'NoProof' engine from ethereum/tests#464 . Since tests has been regenerated those one were failing on block difficulty check. Update ethereum/tests, waiting for cost fix (block test are still commented). * Update tests submodule reference to latest (all test passing except an identified case). Fix block reward of constantinople json. * Restore broken test by using old json tests files. * Use CanonNoSeal instead of a custom engine, still have to include some additional tests code. * Gas upper limit check in json_chain test was bad, moving the test to verification, the test is running in `verify_header_param`. Note that test was previously only for ethash, and now for any engine. * Restore old behavior (gas uper limit only for ethash engine), at the cost of an additional trait method. * Proper rpc test fix. * Update tests submodule, add SStore bug tests. * Fix json issue tabulation. Update tests submodule to latest master (lot of new sstore tests passing) * Switch ethereum/tests to tag 6.0.0-beta.1 (no tests changes from latest synch). * Display hex with separator, use indirection instead of clone for copy types.

* version: mark 2.2.0 beta * ci: remove failing tests for android, windows, and macos (openethereum#9788) * ci: remove failing tests for android, windows, and macos * ci: restore android build jobs * Move state root verification before gas used (openethereum#9841) * Classic.json Bootnode Update (openethereum#9828) * fix: Update bootnodes list to only responsive nodes * feat: Add more bootnodes to classic.json list * feat: Add retested bootnodes * Implement NoProof for json tests and update tests reference (replaces openethereum#9744) (openethereum#9814) * Update test reference. Block test are really not working so I disabled a few by commenting directly in source. * Move ethtest commit cursor. * Implements 'NoProof' engine from ethereum/tests#464 . Since tests has been regenerated those one were failing on block difficulty check. Update ethereum/tests, waiting for cost fix (block test are still commented). * Update tests submodule reference to latest (all test passing except an identified case). Fix block reward of constantinople json. * Restore broken test by using old json tests files. * Use CanonNoSeal instead of a custom engine, still have to include some additional tests code. * Gas upper limit check in json_chain test was bad, moving the test to verification, the test is running in `verify_header_param`. Note that test was previously only for ethash, and now for any engine. * Restore old behavior (gas uper limit only for ethash engine), at the cost of an additional trait method. * Proper rpc test fix. * Update tests submodule, add SStore bug tests. * Fix json issue tabulation. Update tests submodule to latest master (lot of new sstore tests passing) * Switch ethereum/tests to tag 6.0.0-beta.1 (no tests changes from latest synch). * Display hex with separator, use indirection instead of clone for copy types.

cheme added 5 commits October 8, 2018 18:24

Update test reference.

4f6c6ac

Block test are really not working so I disabled a few by commenting directly in source.

Move ethtest commit cursor.

92b33a2

Merge branch 'master' into ethereum_tests_update

b503c56

Implements 'NoProof' engine from ethereum/tests#464 .

2ebbf41

Since tests has been regenerated those one were failing on block difficulty check. Update ethereum/tests, waiting for cost fix (block test are still commented).

Update tests submodule reference to latest (all test passing except an

a1eb0f2

identified case). Fix block reward of constantinople json.

cheme added the A0-pleasereview 🤓 Pull request needs code review. label Oct 12, 2018

Restore broken test by using old json tests files.

2275437

sorpaas reviewed Oct 13, 2018

View reviewed changes

cheme added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 13, 2018

Use CanonNoSeal instead of a custom engine, still have to include some

cef5d5a

additional tests code.

cheme added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Oct 15, 2018

5chdn added this to the 2.2 milestone Oct 15, 2018

5chdn added the M4-core ⛓ Core client code / Rust. label Oct 15, 2018

Gas upper limit check in json_chain test was bad, moving the test to

a6eecf6

verification, the test is running in `verify_header_param`. Note that test was previously only for ethash, and now for any engine.

cheme added 2 commits October 16, 2018 11:37

Restore old behavior (gas uper limit only for ethash engine), at the

a2e170e

cost of an additional trait method.

Proper rpc test fix.

0683616

cheme and others added 3 commits October 16, 2018 14:35

Update tests submodule, add SStore bug tests.

fdf2baf

Merge branch 'master' into ethereum_tests_update

5964c72

prevent zero networkID (openethereum#9763)

73f08b3

* prevent zero networkID, closes openethereum#8345 Signed-off-by: Seun LanLege <[email protected]> * updated networkID of olymic chain spec Signed-off-by: Seun LanLege <[email protected]>

5chdn added the B1-patch-beta 🕷🕷 label Oct 17, 2018

5chdn added 2 commits October 17, 2018 14:52

docs: changelogs for 2.0.8 and 2.1.3 (openethereum#9758)

da6cf33

* docs: add changelog for parity ethereum v2.1.3 beta * docs: add changelog for parity ethereum v2.0.7 stable

ethcore: bump ropsten forkblock checkpoint (openethereum#9775)

1f103ab

sorpaas reviewed Oct 19, 2018

View reviewed changes

Fix json issue tabulation.

b82d0b0

Update tests submodule to latest master (lot of new sstore tests passing)

sorpaas and others added 18 commits October 26, 2018 13:21

Expose config max-round-blocks-to-import (openethereum#9439)

1ff827b

* Expose config max-round-blocks-to-import * Fix test

removed "rustup" & added new runner tag (openethereum#9731)

879e730

* removed "rustup" & added new runner tag * exchanged tag "rust-windows" with "windows" * revert windows tag change

Insert dev account before unlocking (openethereum#9813)

ff13c9c

Update test reference.

d7a7f75

Block test are really not working so I disabled a few by commenting directly in source.

Move ethtest commit cursor.

75540ff

Implements 'NoProof' engine from ethereum/tests#464 .

f8dcc88

Since tests has been regenerated those one were failing on block difficulty check. Update ethereum/tests, waiting for cost fix (block test are still commented).

Update tests submodule reference to latest (all test passing except an

9ab289f

identified case). Fix block reward of constantinople json.

Restore broken test by using old json tests files.

f9c8503

Use CanonNoSeal instead of a custom engine, still have to include some

c9550ae

additional tests code.

Gas upper limit check in json_chain test was bad, moving the test to

5ffd497

verification, the test is running in `verify_header_param`. Note that test was previously only for ethash, and now for any engine.

Restore old behavior (gas uper limit only for ethash engine), at the

57e0aaf

cost of an additional trait method.

Proper rpc test fix.

5a7ec83

Update tests submodule, add SStore bug tests.

e2dc3c2

Fix json issue tabulation.

4c3c350

Update tests submodule to latest master (lot of new sstore tests passing)

Switch ethereum/tests to tag 6.0.0-beta.1 (no tests changes from latest

d6cabd8

synch).

Merge branch 'ethereum_tests_update' of github.com:cheme/parity-ether…

910ffd2

…eum into ethereum_tests_update

Revert to "Fix json issue tabulation."

79508d6

This reverts commit b82d0b0.

cheme mentioned this pull request Oct 26, 2018

Implement NoProof for json tests and update tests reference (replaces #9744) #9814

Merged

cheme closed this Oct 26, 2018

5chdn mentioned this pull request Nov 1, 2018

version: mark 2.2.0 beta #9820

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement NoProof for json tests and update tests reference #9744

Implement NoProof for json tests and update tests reference #9744

cheme commented Oct 12, 2018 •

edited

Loading

parity-cla-bot commented Oct 12, 2018

sorpaas Oct 13, 2018

cheme Oct 13, 2018

5chdn commented Oct 15, 2018

sorpaas commented Oct 16, 2018

cheme commented Oct 16, 2018

sorpaas left a comment

sorpaas Oct 16, 2018

sorpaas Oct 16, 2018

sorpaas Oct 16, 2018

sorpaas Oct 16, 2018

cheme commented Oct 26, 2018

Implement NoProof for json tests and update tests reference #9744

Implement NoProof for json tests and update tests reference #9744

Conversation

cheme commented Oct 12, 2018 • edited Loading

parity-cla-bot commented Oct 12, 2018

sorpaas Oct 13, 2018

Choose a reason for hiding this comment

cheme Oct 13, 2018

Choose a reason for hiding this comment

5chdn commented Oct 15, 2018

sorpaas commented Oct 16, 2018

cheme commented Oct 16, 2018

sorpaas left a comment

Choose a reason for hiding this comment

sorpaas Oct 16, 2018

Choose a reason for hiding this comment

sorpaas Oct 16, 2018

Choose a reason for hiding this comment

sorpaas Oct 16, 2018

Choose a reason for hiding this comment

sorpaas Oct 16, 2018

Choose a reason for hiding this comment

cheme commented Oct 26, 2018

cheme commented Oct 12, 2018 •

edited

Loading