Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Hide most of the logs from cpp example. #10139

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Hide most of the logs from cpp example. #10139

merged 1 commit into from
Jan 7, 2019

Conversation

tomusdrw
Copy link
Collaborator

@tomusdrw tomusdrw commented Jan 7, 2019

CC @niklasad1 does it make sense?

@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. M1-ci 🙉 Continuous integration. labels Jan 7, 2019
@sorpaas sorpaas added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 7, 2019
niklasad1
niklasad1 approved these changes Jan 7, 2019
View reviewed changes
Copy link
Collaborator

@niklasad1 niklasad1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the printouts are redundant anyway because the callbacks are checked by the callback counter. I can probably hide them behind a debug flag or something

@niklasad1 niklasad1 merged commit 5b1d33d into master Jan 7, 2019
@niklasad1 niklasad1 deleted the td-buildfix branch January 7, 2019 09:23
@5chdn 5chdn added this to the 2.3 milestone Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@sorpaas sorpaas sorpaas approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M1-ci 🙉 Continuous integration.
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.
4 participants
@tomusdrw @sorpaas @niklasad1 @5chdn