Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Support MIX. #9767

Merged
merged 8 commits into from
Nov 1, 2018
Merged

Support MIX. #9767

merged 8 commits into from
Nov 1, 2018

Conversation

ethernomad
Copy link
Contributor

MIX is an Ethereum-based blockchain created specifically as a trust-less publishing platform.

https://www.mix-blockchain.org/

MIX can be synchronised with Parity or Geth with a config file, or with Multi-geth without a config file: multi-geth/multi-geth@0fa4762

I would like Parity to have built-in support for MIX also.

It will soon be possible to store MIX on Ledger wallets: MyEtherWallet/etherwallet@ea8c1f0

@parity-cla-bot
Copy link

It looks like @ethernomad hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@ethernomad
Copy link
Contributor Author

[clabot:check]

@parity-cla-bot
Copy link

It looks like @ethernomad signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@5chdn 5chdn added this to the 2.2 milestone Oct 17, 2018
@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. M2-config 📂 Chain specifications and node configurations. labels Oct 17, 2018
@5chdn 5chdn added the B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. label Oct 18, 2018
Copy link
Contributor

@5chdn 5chdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can you place Mix behind Callisto?

@5chdn
Copy link
Contributor

5chdn commented Oct 18, 2018

Why is there a difference between:

@ethernomad
Copy link
Contributor Author

Which difference are you referring to?

@ethernomad
Copy link
Contributor Author

MIX is directly behind Callisto everywhere. Do you want it after?

@5chdn
Copy link
Contributor

5chdn commented Oct 23, 2018

Block explorer shows 6.5 million blocks, network status 2.9 million

@ethernomad
Copy link
Contributor Author

Block explorer shows 6.5 million blocks, network status 2.9 million

You have metamask enabled.

Copy link
Collaborator

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs to be merged/rebased to master

Copy link
Collaborator

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but it has conflicts need to merged/rebased to master

@5chdn 5chdn modified the milestones: 2.2, 2.3 Oct 29, 2018
Copy link
Collaborator

@sorpaas sorpaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The block number bug that @5chdn experience is probably a blockchain explorer bug (having browser web3 provider makes the explorer to be on another chain).

@5chdn 5chdn merged commit b26f86d into openethereum:master Nov 1, 2018
@5chdn 5chdn added the A8-looksgood 🦄 Pull request is reviewed well. label Nov 1, 2018
@5chdn 5chdn removed the A0-pleasereview 🤓 Pull request needs code review. label Nov 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. M2-config 📂 Chain specifications and node configurations. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants