This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Update Callisto block reward code to support HF1 #9811
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like @yograterol signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
5chdn
approved these changes
Oct 26, 2018
5chdn
added
A2-insubstantial 👶
Pull request requires no code review (e.g., a sub-repository hash update).
A8-looksgood 🦄
Pull request is reviewed well.
M2-config 📂
Chain specifications and node configurations.
labels
Oct 26, 2018
andresilva
added
the
A3-inprogress ⏳
Pull request is in progress. No review needed at this stage.
label
Oct 29, 2018
andresilva
approved these changes
Oct 29, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but waiting on PR author to confirm that it's good to merge.
5chdn
added
the
A3-stale 🍃
Pull request did not receive any updates in a long time. No review needed at this stage. Close it.
label
Oct 31, 2018
@yograterol what's the status of this? |
yograterol
changed the title
[WIP] Update Callisto block reward code to support HF1
Update Callisto block reward code to support HF1
Nov 6, 2018
@5chdn please merge this, this works. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A2-insubstantial 👶
Pull request requires no code review (e.g., a sub-repository hash update).
A3-inprogress ⏳
Pull request is in progress. No review needed at this stage.
A3-stale 🍃
Pull request did not receive any updates in a long time. No review needed at this stage. Close it.
A8-looksgood 🦄
Pull request is reviewed well.
M2-config 📂
Chain specifications and node configurations.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callisto will introduce rewards changes on block 1,400,000
Changes on block reward smart contract there: EthereumCommonwealth/block-reward@55a2433
Please don't merge yet. We're testing the PR.