This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Health endpoint #9847
Merged
Health endpoint #9847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
niklasad1
approved these changes
Nov 1, 2018
|
@tomusdrw shall this be backported? |
|
@niklasad1 no, I don't think backporting is required - it's a new feature not really a bugfix. |
ngotchac
reviewed
Nov 2, 2018
rpc/src/v1/impls/parity.rs
Outdated
| @@ -481,4 +487,21 @@ impl<C, M, U, S> Parity for ParityClient<C, M, U> where | |||
| fn submit_work_detail(&self, nonce: H64, pow_hash: H256, mix_hash: H256) -> Result<H256> { | |||
| helpers::submit_work_detail(&self.client, &self.miner, nonce, pow_hash, mix_hash) | |||
| } | |||
|
|
|||
| fn status(&self) -> Result<()> { | |||
| let has_peers = self.client.spec_name() == "developmentchain" || self.sync.status().num_peers > 0; | |||
There was a problem hiding this comment.
Can't we have a more generic method to check if it's the dev chain? Or couldn't it be the same check as for the light implementation?
There was a problem hiding this comment.
Good point, was trying to look for any detection we do already, but haven't found anything.
In light we don't really have spec_name exposed, but I agree that current way is suboptimal.
I'll try to figure something out.
There was a problem hiding this comment.
@ngotchac addressed, could you have a look?
tomusdrw
added
A3-inprogress ⏳
|
Also please don't forget the doc 👼 |
ngotchac
approved these changes
Nov 5, 2018
ngotchac
added
A8-looksgood 🦄
niklasad1
added
A7-looksgoodtestsfail 🤖
tomusdrw
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7560
Closes #9401
Introduces new RPC method
parity_nodeStatusthat return OK in case the node is not syncing and you have at least one peer (exception: development chain).This method is then used as a health API of HTTP server.