This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
allow rust-nightly builds fail in nightly builds #9944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @gabreal signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
niklasad1
approved these changes
Nov 20, 2018
|
I filed an issue for rust rust-lang/rust#56069. |
|
@gabreal Since test-nightly is in optional stage, is it technically allowed to fail already? |
|
The whole pipeline is marked as failed regardless of a stage being called optional - that's just a name. |
tomusdrw
approved these changes
Nov 20, 2018
tomusdrw
added
A8-looksgood 🦄
|
but even with allow_failure the job will still be run, its result just won't be counted to the final result. I think it's more about notifications here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://doc.rust-lang.org/cargo/guide/continuous-integration.html#gitlab-ci
allow rust-nightly builds to fail
https://gitlab.parity.io/parity/parity-ethereum/pipelines/26136