Support 'pending' block in RPC #1007
Conversation
|
|
||
| fn balance(&self, address: &Address) -> U256 { | ||
| let sealing_work = self.sealing_work.lock().unwrap(); | ||
| sealing_work.peek_last_ref().map_or(x!(0), |b| b.block().fields().state.balance(address)) |
There was a problem hiding this comment.
Maybe you could use self.map_sealing_work this would actually enable and prepare sealing?
There was a problem hiding this comment.
There is no need to actually start sealing here
There was a problem hiding this comment.
what about when there's no work (peer_last_ref() returns None) and it is querying an account with a non-zero balance?
There was a problem hiding this comment.
Now miner will forward calls to client if not sealing. Checking sealing status in RPC module would be a subject to race condition. This whole module needs to be refactored later. Miner module should keep a reference to BlockChainClient
gavofyork
added
A4-gotissues 💥
arkpar
added
A0-pleasereview 🤓
|
looks better now - are there any tests? |
|
Tests would require substantial refactoring of |
Partially takes care of #926