Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

IPC JSON RPC (for external interface) #1009

Merged
merged 6 commits into from
Apr 28, 2016
Merged

IPC JSON RPC (for external interface) #1009

merged 6 commits into from
Apr 28, 2016

Conversation

NikVolf
Copy link
Contributor

@NikVolf NikVolf commented Apr 27, 2016

nano-worker over jsonrpc_core::IoHandler

@NikVolf NikVolf added the A0-pleasereview 🤓 Pull request needs code review. label Apr 27, 2016
@NikVolf NikVolf changed the title IPC JSON RPC IPC JSON RPC (for external interface) Apr 27, 2016
@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Apr 28, 2016

::std::thread::spawn(move || {
while !worker_is_stopping.load(Ordering::Relaxed) {
worker.poll()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to handle possible panics.

@tomusdrw tomusdrw added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Apr 28, 2016
@NikVolf NikVolf added A0-pleasereview 🤓 Pull request needs code review. and removed A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. labels Apr 28, 2016
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Apr 28, 2016
@gavofyork gavofyork merged commit a86c39f into master Apr 28, 2016
@gavofyork gavofyork deleted the ipc-json-rpc branch April 28, 2016 14:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants