This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fixing status page displaying homestead #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -241,7 +241,7 @@ impl Configuration { | |||
| pub fn network_settings(&self) -> NetworkSettings { | |||
| NetworkSettings { | |||
| name: self.args.flag_identity.clone(), | |||
| chain: self.args.flag_chain.clone(), | |||
There was a problem hiding this comment.
why is this even needed? it means that flag_testnet and flag_chain are interpreted in two different positions, leading to this bug. self.args should be interpreted in only one position for each field and network shouldn't need to care about what chain it is.
There was a problem hiding this comment.
You're right. I've update the code and added some tests.
gavofyork
added
A4-gotissues 💥
tomusdrw
added
A0-pleasereview 🤓
gavofyork
added
A8-looksgood 🦄
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when running with --testnet switch.