This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Change eth_signAndSendTransaction to personal_SignAndSendTransaction #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| fn dispatch_transaction(&self, signed_transaction: SignedTransaction) -> Result<Value, Error> { |
There was a problem hiding this comment.
That seems to be copy pasted from impls/eth.rs can we move it to some common place (helpers perhaps?)
tomusdrw
added
A8-looksgood 🦄
rphmeier
force-pushed
the
personal_sign_and_send
branch
from
dabb32b to
9b3071e
Compare
|
rebased onto latest master |
rphmeier
added
A0-pleasereview 🤓
rphmeier
force-pushed
the
personal_sign_and_send
branch
from
9b3071e to
2a316ab
Compare
this has the added benefit of allowing the removal of redundant upgrades.
rphmeier
force-pushed
the
personal_sign_and_send
branch
from
2a316ab to
b28a841
Compare
tomusdrw
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1140