This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
devtools helpers extended #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NikVolf
commented
May 31, 2016
NikVolf
commented
- stop guard
- random strings
| // You should have received a copy of the GNU General Public License | ||
| // along with Parity. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| //! Random path |
| } | ||
|
|
||
| pub fn random_str(len: usize) -> String { | ||
| (0..len).map(|_| ((random::<f32>() * 26.0) as u8 + 97) as char).collect() |
There was a problem hiding this comment.
random_alpha_lowercase might be a more descriptive name
There was a problem hiding this comment.
better keep it small until we have more than just one
There was a problem hiding this comment.
random::<f32>? really? what about plain old random::<u8>() % 26?
There was a problem hiding this comment.
It is not strictly uniform, not that it matters in this function
There was a problem hiding this comment.
it is not used anywhere except tests and it's been there for ages
it is not about this pr
gavofyork
added
A8-looksgood 🦄
NikVolf
added
A0-pleasereview 🤓
rphmeier
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.