Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Splitting RPC Apis into more fine-grained sets #1234

Merged
merged 2 commits into from
Jun 7, 2016
Merged

Conversation

tomusdrw
Copy link
Collaborator

@tomusdrw tomusdrw commented Jun 7, 2016

No description provided.

@tomusdrw tomusdrw added the A0-pleasereview 🤓 Pull request needs code review. label Jun 7, 2016
@rphmeier
Copy link
Contributor

rphmeier commented Jun 7, 2016

is the motivation of this PR to lay the foundation for having all ethcore_set* methods be authenticated by a trusted signer?

@tomusdrw
Copy link
Collaborator Author

tomusdrw commented Jun 7, 2016

In distant future - yes.

For now we will have additional cookie/token authentication for ethcore_set. We also want people to run RPC with ethcore methods, but without those "unsafe" methods from ethcore_set.

@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. and removed A0-pleasereview 🤓 Pull request needs code review. A8-looksgood 🦄 Pull request is reviewed well. labels Jun 7, 2016
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. labels Jun 7, 2016
@gavofyork gavofyork merged commit be435cd into master Jun 7, 2016
@gavofyork gavofyork deleted the apis-split branch June 7, 2016 20:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants