Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

clarify build instructions #1287

Merged
merged 4 commits into from
Jun 15, 2016
Merged

Conversation

rphmeier
Copy link
Contributor

No description provided.

@rphmeier rphmeier added the A0-pleasereview 🤓 Pull request needs code review. label Jun 14, 2016
@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jun 14, 2016
@@ -49,14 +49,13 @@ $ curl https://sh.rustup.rs -sSf | sh

- Windows

Make sure you have Visual Studio 2015 with C++ support installed, download and run [rustup](https://static.rust-lang.org/rustup/dist/x86_64-pc-windows-msvc/rustup-init.exe) and use the following command to setup msvc toolchain:
Make sure you have Visual Studio 2015 with C++ support installed. Next, use the following commands to install and set up the msvc toolchain:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command won't work unless user installs rustup first

@arkpar arkpar added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Jun 14, 2016
@rphmeier rphmeier added A0-pleasereview 🤓 Pull request needs code review. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels Jun 15, 2016
@arkpar
Copy link
Collaborator

arkpar commented Jun 15, 2016

Indentation for Windows and Linux sections looks different.

@arkpar arkpar added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jun 15, 2016
@rphmeier rphmeier added A0-pleasereview 🤓 Pull request needs code review. and removed A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. labels Jun 15, 2016
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jun 15, 2016
@rphmeier rphmeier merged commit 6b852a0 into openethereum:master Jun 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants