This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix lock order when updating sealing #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A8-looksgood 🦄
| @@ -106,7 +106,8 @@ impl Miner { | |||
| #[cfg_attr(feature="dev", allow(cyclomatic_complexity))] | |||
| fn prepare_sealing(&self, chain: &MiningBlockChainClient) { | |||
| trace!(target: "miner", "prepare_sealing: entering"); | |||
| let transactions = self.transaction_queue.lock().unwrap().top_transactions(); | |||
There was a problem hiding this comment.
This was actually working as expected - the lock should be dropped cause top_transactions is doing a copy.
I didn't wanted to keep transaction queue locked when transactions are executed.
But if you believe it might be dangerous I'm ok with it.
arkpar
added
A3-inprogress ⏳
arkpar
added
A0-pleasereview 🤓
tomusdrw
added
A8-looksgood 🦄
gavofyork
added
A0-pleasereview 🤓
|
I think the braces (block) are not really needed in, but can live with them :) |
arkpar
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.