Presale wallet

[debris]

• fixed crash when presale wallet password was incorrect
• ethstore command for importing presale wallet
• parity command for importing presale wallet (geth compatible)

[gavofyork]

<password> is a file containing the password, right?

[gavofyork]

looks like you're wanting to provide password as a CLI arg. that's not a particularly good idea - some people reuse passwords and would prefer not to see it in plain text or stored in the console history.

[debris]

parity uses password file for backwards compatibility with geth.
ethstore uses plain text. I find it much more flexible than using files. If people want to use password files they can always do ethstore import-wallet ethwallet.json $(cat pass.txt)

[tomusdrw]

The problem is that by default people won't do that and their password will be readable in $ history.

[debris]

imho ethstore is a developer tool. Developers should know their environment and that typing plain password might be insecure

[gavofyork]

developers don't generally need to import a presale wallet.

people who bought in the presale do.

[gavofyork]

(if you really like, you could try password-file name as a password itself if the file doesn't exist)