This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Configurable gas limit cap. #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else { | ||
| max(gas_floor_target, gas_limit - gas_limit / bound_divisor + 1.into() + (header.gas_used * 6.into() / 5.into()) / bound_divisor) | ||
| max(gas_ceil_target, | ||
| max(gas_floor_target, |
arkpar
added
A4-gotissues 💥
gavofyork
added
A0-pleasereview 🤓
arkpar
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The point of this is to provide an option to the user so they can cap the rise of gas limit. Gas limit strategy is to increase as long as there is significant gas usage in the block. For fork voting, this means a miner taking a large amount of transaction spam could accidentally keep their gas limit substantially above the target floor. This prevents that situation by allowing a cap, beyond which no amount of transaction volume could push the gas limit.