Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Sync IPC interface #1584

Merged
merged 46 commits into from
Jul 14, 2016
Merged

Sync IPC interface #1584

merged 46 commits into from
Jul 14, 2016

Conversation

NikVolf
Copy link
Contributor

@NikVolf NikVolf commented Jul 11, 2016

[x] sorting out with multiple handshake structures spawned for each service in codegen - #1586

@NikVolf NikVolf added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Jul 12, 2016
@NikVolf NikVolf closed this Jul 12, 2016
@NikVolf NikVolf reopened this Jul 12, 2016
@NikVolf NikVolf closed this Jul 13, 2016
@NikVolf NikVolf reopened this Jul 13, 2016
@NikVolf NikVolf closed this Jul 13, 2016
@NikVolf NikVolf reopened this Jul 13, 2016
@NikVolf NikVolf closed this Jul 13, 2016
@NikVolf NikVolf reopened this Jul 13, 2016
@coveralls
Copy link

coveralls commented Jul 13, 2016

Coverage Status

Changes Unknown when pulling 0555b9a on sync-ipc-rpc into * on master*.

let out_dir = env::var_os("OUT_DIR").unwrap();

// sync interface
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's probably for a next PR but can we replace the build scripts with something like:

fn main() {
  let paths = HashMap::new();
  ethcore_ipc_codegen::build(paths);
}

This will allow us to have just codegen as build dependency, without any syntex stuff. Might be also much easier to keep it in sync in future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep i will do it when will be sorting things with compiler plugins

@gavofyork
Copy link
Contributor

basic style and premise lgtm.refctoring of @arkpar 's code though...

@tomusdrw
Copy link
Collaborator

Seems ok for me too. I don't feel I have enough knowledge to decide, though.

@tomusdrw tomusdrw closed this Jul 14, 2016
@tomusdrw tomusdrw reopened this Jul 14, 2016
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 14, 2016
@arkpar arkpar merged commit 44bc8a0 into master Jul 14, 2016
@coveralls
Copy link

coveralls commented Jul 14, 2016

Coverage Status

Changes Unknown when pulling 3ec78b5 on sync-ipc-rpc into * on master*.

@NikVolf NikVolf deleted the sync-ipc-rpc branch July 18, 2016 15:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants