-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
Changes Unknown when pulling 0555b9a on sync-ipc-rpc into * on master*. |
let out_dir = env::var_os("OUT_DIR").unwrap(); | ||
|
||
// sync interface | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's probably for a next PR but can we replace the build scripts with something like:
fn main() {
let paths = HashMap::new();
ethcore_ipc_codegen::build(paths);
}
This will allow us to have just codegen
as build dependency, without any syntex stuff. Might be also much easier to keep it in sync in future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep i will do it when will be sorting things with compiler plugins
basic style and premise lgtm.refctoring of @arkpar 's code though... |
Seems ok for me too. I don't feel I have enough knowledge to decide, though. |
Changes Unknown when pulling 3ec78b5 on sync-ipc-rpc into * on master*. |
[x] sorting out with multiple handshake structures spawned for each service in codegen - #1586