Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Use single binary for ipc modules #1710

Merged
merged 2 commits into from
Jul 25, 2016
Merged

Use single binary for ipc modules #1710

merged 2 commits into from
Jul 25, 2016

Conversation

NikVolf
Copy link
Contributor

@NikVolf NikVolf commented Jul 25, 2016

No description provided.

@NikVolf NikVolf added the A0-pleasereview 🤓 Pull request needs code review. label Jul 25, 2016
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 25, 2016
@gavofyork
Copy link
Contributor

the pub fn main stuff is a bit weird...

@coveralls
Copy link

coveralls commented Jul 25, 2016 •
edited
Loading

Coverage Status

Changes Unknown when pulling 6a41a4f on single-bin into * on master*.

@rphmeier
Copy link
Contributor

pub fn main is idiomatically fine

@gavofyork gavofyork merged commit f614a69 into master Jul 25, 2016
@gavofyork gavofyork deleted the single-bin branch July 25, 2016 22:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NikVolf @gavofyork @coveralls @rphmeier