This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix state not using "account_starting_nonce" #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| let secret = Secret::from_str("8a283037bb19c4fed7b1c569e40c7dcff366165eb869110a1b11532963eb9cb2").unwrap(); | ||
| let tester = EthTester::from_spec_provider(|| Spec::load(POSITIVE_NONCE_SPEC)); | ||
| let address = tester.accounts.insert_account(secret, "").unwrap(); |
There was a problem hiding this comment.
why inserting it at all? the original fail case was when the account didn't exist, wasn't it?
There was a problem hiding this comment.
@gavofyork
i guess it is when there were no transaction for existing address also?
There was a problem hiding this comment.
But it doesn't matter if it's a local account or no, you could test 0x0 adddress and it would be fine.
|
Sorry, about the JSON, I wasn't aware that there are other inline specs in this file, I was rather thinking of putting the files to |
tomusdrw
added
A6-mustntgrumble 💦
|
@tomusdrw |
NikVolf
added
A0-pleasereview 🤓
|
test is failing |
arkpar
added
A4-gotissues 💥
NikVolf
added
A0-pleasereview 🤓
gavofyork
added
A8-looksgood 🦄
NikVolf
added
A0-pleasereview 🤓
|
so i changed |
gavofyork
added
A8-looksgood 🦄
arkpar
pushed a commit
that referenced
this pull request
Aug 5, 2016
* failng test * use account_starting_nonce instead of zero * simplier test * jsons are getting closer * incorrect test client and incorrect tests fix * null_morden is using 0x0 starting nonce * replaced json with the correct one * superwhatever line
gavofyork
pushed a commit
that referenced
this pull request
Aug 5, 2016
* Fix up the VM trace. * Fix test. * Fix state not using "account_starting_nonce" (#1830) * failng test * use account_starting_nonce instead of zero * simplier test * jsons are getting closer * incorrect test client and incorrect tests fix * null_morden is using 0x0 starting nonce * replaced json with the correct one * superwhatever line * Bump json-ipc-server again (#1839) * bump ipc version * bumping once more * v1.2.4 * Fixed reported max height and transaction propagation (#1852) * Fixed max height and transaction propagation * Fixed tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.