Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Purging .derefs, fixing clippy warnings. #1890

Merged
merged 5 commits into from
Aug 10, 2016
Merged

Purging .derefs, fixing clippy warnings. #1890

merged 5 commits into from
Aug 10, 2016

Conversation

tomusdrw
Copy link
Collaborator

@tomusdrw tomusdrw commented Aug 9, 2016

No description provided.

@tomusdrw tomusdrw added the A0-pleasereview 🤓 Pull request needs code review. label Aug 9, 2016
@rphmeier
Copy link
Contributor

rphmeier commented Aug 9, 2016

Down with .deref!

@coveralls
Copy link

coveralls commented Aug 9, 2016

Coverage Status

Coverage decreased (-0.05%) to 86.168% when pulling 5056cd8 on fix-warnings into 73c19fd on master.

@NikVolf NikVolf added A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 9, 2016
Conflicts:
	ethcore/src/trace/db.rs
@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. and removed A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. labels Aug 10, 2016
@coveralls
Copy link

coveralls commented Aug 10, 2016

Coverage Status

Coverage decreased (-0.02%) to 86.321% when pulling 788d7c3 on fix-warnings into 4efddb9 on master.

@debris
Copy link
Collaborator

debris commented Aug 10, 2016

isn't single &* enough in most of these places?

@tomusdrw
Copy link
Collaborator Author

I think it's because there is let engine = &spec.engine in most cases - I will try to simplify it further.

@tomusdrw tomusdrw added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 10, 2016
@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Aug 10, 2016
@coveralls
Copy link

coveralls commented Aug 10, 2016

Coverage Status

Coverage decreased (-0.08%) to 86.258% when pulling f3aa210 on fix-warnings into 4efddb9 on master.

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 10, 2016
@coveralls
Copy link

coveralls commented Aug 10, 2016

Coverage Status

Coverage decreased (-0.02%) to 86.31% when pulling d73084c on fix-warnings into 8018b69 on master.

@arkpar arkpar merged commit a427208 into master Aug 10, 2016
arkpar pushed a commit that referenced this pull request Aug 12, 2016
* Fixing clippy warnings

* Purging derefs

* Simplifying engine derefs

* Simplifying more engine derefs
arkpar added a commit that referenced this pull request Aug 12, 2016
* RPC errors & logs (#1845)

* Refactoring errors in RPC

* Updating jsonrpc-core

* Fixing code_at

* Avoid mentioning obvious segments in proof

[ci:skip]

* fixed cache_manager lock order

* Purging .derefs, fixing clippy warnings. (#1890)

* Fixing clippy warnings

* Purging derefs

* Simplifying engine derefs

* Simplifying more engine derefs

* Adding more details to miner log

* fixed #1889, .DS_Store is no longer treated as key file (#1892)

* fixed #1889, .DS_Store is no longer treated as key file

* ethstore filters directories, hidden files and common system files

* fixed compiling

* fix regression with geth dir

* fix regression with geth dir

* Fix ipc compilation and add ipc feature to test targets (#1902)

* fix compilation and add it to the ci run

* no separator?

* use quotes and spaces

* RocksDB version bump

* Don't return deleted nodes that are not yet flushed (#1908)

* polling & connection timeouts (#1910)

* Peers RPC + UI displaying active/connected/max peers (#1915)

* Peers API

* Bumping Parity-UI

* Fixing tests

* Save nodes removed from backing_overlay until commit (#1917)
@tomusdrw tomusdrw deleted the fix-warnings branch August 22, 2016 13:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants