Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

LRU cache for dapps #2006

Merged
merged 1 commit into from
Aug 30, 2016
Merged

LRU cache for dapps #2006

merged 1 commit into from
Aug 30, 2016

Conversation

tomusdrw
Copy link
Collaborator

@tomusdrw tomusdrw commented Aug 25, 2016

Related: #1176

Conflicts:
	dapps/Cargo.toml
	dapps/src/lib.rs
@tomusdrw tomusdrw added the A0-pleasereview 🤓 Pull request needs code review. label Aug 25, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 86.788% when pulling 8634daa on dapps-lru2 into 3e07135 on master.

@rphmeier
Copy link
Contributor

Wow, LinkedHashMap is great! Good crate to know about.

@tomusdrw
Copy link
Collaborator Author

Yeah, there is also: https://github.com/contain-rs/lru-cache/ (but doesn't let you take additional actions when old items are purged).

I also thought about implementing simple LinkedHashMap on my own, but then had a look at LinkedHashMap code and it seems to be very well-written, pretty sure I wouldn't be able to do anything better.

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 29, 2016
@arkpar arkpar merged commit 6f321d9 into master Aug 30, 2016
@tomusdrw tomusdrw deleted the dapps-lru2 branch September 2, 2016 08:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants