Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

gitlab testing & build processes #2090

Merged
merged 7 commits into from
Sep 19, 2016
Merged

gitlab testing & build processes #2090

merged 7 commits into from
Sep 19, 2016

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Sep 14, 2016 •
edited
Loading

Allow the build of the JavaScript side to take place on GitLab. This includes -

  • running lint (fixing small liniting issues so the build passes)
  • running tests

Future work will include:

  • building
  • deploy & publishing

@parity-cla-bot
Copy link

It looks like @jacogr signed our Contributor License Agreement. 👍

Many thanks,

Ethcore CLA Bot

@jacogr jacogr added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M-UI A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Sep 14, 2016
@General-Beck
Copy link
Contributor

LGTM and it works

@General-Beck General-Beck added A8-backport 🕸 Pull request is already reviewed well in another branch. and removed A0-pleasereview 🤓 Pull request needs code review. labels Sep 18, 2016
@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A8-backport 🕸 Pull request is already reviewed well in another branch. labels Sep 18, 2016
@jacogr jacogr merged commit 4396952 into js Sep 19, 2016
@jacogr jacogr deleted the js-gitlab-testing branch September 19, 2016 13:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacogr @parity-cla-bot @General-Beck