This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Remove panickers from trie iterators #2209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows proper recovery from a premature periodic snapshot
rphmeier
added
A0-pleasereview 🤓
|
I wish there were a better heuristic for "are we actually at the head of the chain" than "are we idle or has the block queue got less than 3 entries". Maybe keep track of the best block number we've seen our (reliable) peers broadcast and compare it to where we are now? |
|
indeed - sync subsystem should have sufficient information to be able to give an accurate answer. |
gavofyork
added
A8-looksgood 🦄
gavofyork
approved these changes
Sep 21, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes use of it to detect when a prematurely-started periodic snapshot has failed because the state it was snapshotting got pruned out.