This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Blockchain tests and some helpers for guarding temp directory #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikVolf
changed the title
| @@ -32,6 +33,18 @@ impl Drop for RandomTempPath { | |||
| } | |||
| } | |||
|
|
|||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
nah, it's already in test space
| header.extra_data = match extra { | ||
| Some(extra_data) => extra_data, | ||
| None => { | ||
| let base = (order & 0x000000ff) as u8; |
There was a problem hiding this comment.
where? looks good from here )
There was a problem hiding this comment.
Not aligned with the next line:)
There was a problem hiding this comment.
pretty aligned to me :)
| let bc = BlockChain::new( | ||
| &create_unverifiable_block( | ||
| 0, | ||
| H256::from_str("0000000000000000000000000000000000000000000000000000000000000000").unwrap()), |
There was a problem hiding this comment.
Maybe there should be H256::zero() like we have for U256?
tomusdrw
added
A8-looksgood 🦄
| result: client | ||
| } | ||
| } | ||
|
|
NikVolf
added
A0-pleasereview 🤓
gavofyork
pushed a commit
that referenced
this pull request
Jan 29, 2016
Blockchain tests and some helpers for guarding temp directory
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.