very basic dapp add/remove interface #2721
Conversation
|
It looks like this contributor signed our Contributor License Agreement. 👍 Many thanks, Ethcore CLA Bot |
|
Need to fit in with the rest of the L&F. Functionality seems spot-on though. Would have loved to have at least the 2 categories as well, the name itself it just not enough. |
jacogr
added
A4-gotissues 💥
|
Just wondered because you said it may not be worth it as the ui is going to change soon anyways. |
|
Well, we have a ui/Modal - just by using that things would have (a) appeared on a consistent location with the rest So I'm actually guessing it would have been less work (have not reviewed the code as of yet) |
derhuerst
added
A0-pleasereview 🤓
| @@ -38,7 +38,7 @@ export default class Summary extends Component { | |||
| return null; | |||
| } | |||
|
|
|||
| const url = `/app/${app.local ? 'local' : 'global'}/${app.url}`; | |||
| const url = `/app/${app.local ? 'local' : 'global'}/${app.id}`; | |||
There was a problem hiding this comment.
Does this actually work now? For built-ins the id is the sha3, so in the dapp we may try to load sha3.html?
We need the hash id, otherwise we cannot reliably register images.
|
|
||
| const hardcoded = [ | ||
| { | ||
| id: 'basiccoin', |
|
|
||
| return globalApps.map(this.renderApp); | ||
| return Promise.all(available.map((app) => dappReg.getImage(sha3(app.id)))) |
There was a problem hiding this comment.
The issue is now that we do the expensive sha3 every cycle and as authors have no way of seeing what it is to manage :(
There was a problem hiding this comment.
Sorry wrong about each cycle, but we still need the sha3 to display somewhere - so either pre-calculate and add it to the structure or revert. The sha3 is the actual id that it is registered with on dappreg, cannot do without.
There was a problem hiding this comment.
but we still need the sha3 to display somewhere - so either […] add it to the structure or revert.
We didn't show it before afaict. Will think of some reasonable place to show it.
|
I think the hash is irrelevant to most users, but still needs to be accessible for those technically interested. To keep the visual noise low, I added them to the "customise dapp list" modal.
|
|
Cool, will go through as soon as my Morden is sync-ing again. Agreed with you on the visual noise. |
jacogr
added
A8-looksgood 🦄
This PR addresses #2674 in parts. I just implemented checkboxes instead of sets of dapps, as I wasn't sure it's actually needed if the plan is to get to a full-blown store.