This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Update loading splash to fit in with l&f #3685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
added
A0-pleasereview 🤓
ngotchac
reviewed
Nov 29, 2016
| color: #ddd; | ||
| background: white; | ||
| font-family: 'Roboto', sans-serif; | ||
| font-size: 16px; |
There was a problem hiding this comment.
Why not using em font size ?
There was a problem hiding this comment.
Material-UI defaults to 16px, so sticking with that so there is no jarring effect. (Bear in mind that this gets replaced in some dapps with "Loading Application" as soon as it does it's thing so there is no "o, it looks different now" effect - the dapps are also at 2em for the loading font)
|
I agree, it looks better. I think we could have a CSS spinner for more dynamic loading, if we want to go down that road. |
ngotchac
added
A6-mustntgrumble 💦
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Driving me a bit batty, @ngotchac as discussed.