This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
block: enforce gas limit falls within engine bounds #3809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-pleasereview 🤓
rphmeier
commented
Dec 11, 2016
| @@ -125,8 +125,9 @@ pub trait Engine : Sync + Send { | |||
| self.verify_block_basic(header, None).and_then(|_| self.verify_block_unordered(header, None)) | |||
| } | |||
|
|
|||
| /// Don't forget to call Super::populate_from_parent when subclassing & overriding. | |||
There was a problem hiding this comment.
this comment didn't make much sense so I didn't see a reason to keep it.
arkpar
added
A8-looksgood 🦄
|
Changes Unknown when pulling 9252ebf on mining-min-gas-limit into ** on master**. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3760
Ideally I think the best thing to do would be to no longer expose
CommonParamsand allow engines to internally manage the ranges while exposing nothing more than a simple validation/creation interface as a black box.