Fix Secure API hangs #3927
Fix Secure API hangs #3927
Conversation
|
Changes Unknown when pulling 66ee764 on ng-ws-fix into ** on master**. |
|
|
||
| // Try tokens from localstorage, then from hash | ||
| this._tokensToTry = [ sysuiToken, nextToken ].filter((t) => t && t.length); | ||
| this._tokens = [ |
There was a problem hiding this comment.
What about this case - https://github.com/ethcore/parity/issues/3620
(In this case there is a sysuiToken, however we need to try with initial to generate a token. Basically would try nextToken || 'initial' on line 36, i.e. in this case these is a syuiToken, but won't be a nextToken - first would fail, second would succeed)
|
Much cleaner. Would just explicitly cater for the case where the store is cleared, sysuiToken is thus invalid and we never try |
|
Should be ok now ! |
|
Great. Just going to give it a run-through with scenarios, but code looks good. |
jacogr
added
A8-looksgood 🦄
|
Tested with valid, invalid, auth passed, initial, all seems to be on-spec. |
Fixes #3811
The Secure API has been partially rewritten, and is using Promise based connection. No unnecessary calls are made, and the right endpoint is used (previously, 8180 was used in Dev).
Small changes to Wepback have been made to reduce script files size. Firefox still has some troubles (freezes) loading the UI when dev tools is open. Seems to be fine otherwise.