Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

second (and last) part of rlp refactor #4901

Merged
merged 33 commits into from
Mar 22, 2017
Merged

second (and last) part of rlp refactor #4901

merged 33 commits into from
Mar 22, 2017

Conversation

debris
Copy link
Collaborator

@debris debris commented Mar 14, 2017

based on #4873

changes:

  • rlp benches moved from ethcore-util to rlp
  • removed redundant View trait
  • removed RlpDecodable trait
  • split value and list deserialization (there are new methods: as_list and list_at)
  • 30% faster deserialization

benches

  • old
test bench_decode_nested_empty_lists ... bench:         395 ns/iter (+/- 33)
test bench_decode_u256_value         ... bench:         104 ns/iter (+/- 63)
test bench_decode_u64_value          ... bench:          42 ns/iter (+/- 2)
  • new
test bench_decode_nested_empty_lists ... bench:         243 ns/iter (+/- 72)
test bench_decode_u256_value         ... bench:          69 ns/iter (+/- 11)
test bench_decode_u64_value          ... bench:          31 ns/iter (+/- 5)

@debris debris requested review from arkpar and rphmeier March 14, 2017 11:09
@debris debris added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Mar 14, 2017
@arkpar arkpar requested a review from gavofyork March 14, 2017 17:36
@debris
Copy link
Collaborator Author

debris commented Mar 21, 2017

one more ;) @gavofyork @NikVolf

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 22, 2017
@debris debris merged commit 044d070 into master Mar 22, 2017
@debris debris deleted the rlp_deserialization branch March 22, 2017 13:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants