This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Implement PIP messages, request builder, and handlers #4945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-pleasereview 🤓
tomusdrw
reviewed
Mar 17, 2017
| return usize::MAX; | ||
| pub fn compute_cost(&self, request: &Request) -> U256 { | ||
| match *request { | ||
| Request::Headers(ref req) => self.costs.headers * req.max.into(), |
There was a problem hiding this comment.
Probably would be better to use saturating_ops here?
| /// Compute the cost of a set of requests. | ||
| /// This is the base cost plus the cost of each individual request. | ||
| pub fn compute_cost_multi(&self, requests: &[Request]) -> U256 { | ||
| requests.iter().fold(self.costs.base, |cost, req| cost + self.compute_cost(req)) |
|
merged with master to trigger the CI build |
|
Looks good overall. To huge too look into details. |
arkpar
added
A8-looksgood 🦄
This was referenced Mar 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OnDemand(and by extension RPC) still uses these messages inefficiently. A more sophisticated dispatch mechanism will come in a follow-up PR.Should be merged after #4934
Information for reviewers:
ethcore-lightimplemented a bastardized version of LES.