Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Export account RPC #4967

Merged
merged 3 commits into from
Mar 23, 2017
Merged

Export account RPC #4967

merged 3 commits into from
Mar 23, 2017

Conversation

tomusdrw
Copy link
Collaborator

Related #4824

Also adds documentation to ethstore and cleans up some outdated functions of ethstore CLI.

@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. M6-rpcapi 📣 RPC API. labels Mar 20, 2017
debris
debris reviewed Mar 21, 2017
View reviewed changes
ethstore/src/dir/paths.rs
let mut home = home();
home.push(".ethereum");
home
}
Copy link
Collaborator

@debris debris Mar 21, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be good to make a standalone module from it. in #4956 I moved util/src/path.rs → util/path/src/lib.rs

would be nice to merge these two together

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since both of those PRs are not merged yet I think it would be best to do it separately. Logged: #4972

debris
debris reviewed Mar 21, 2017
View reviewed changes
ethstore/src/bin/ethstore.rs
path if path.starts_with("parity") => {
let chain = path.split('-').nth(1).unwrap_or("ethereum");
let path = paths::parity(chain);
Box::new(RootDiskDirectory::create(path)?)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not really backwards compatible, is it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for parity (loads mainnet), parity-testnet is not really well defined currently, we can alias it to parity-kovan if you think it would be better.

@CraigglesO CraigglesO mentioned this pull request Mar 21, 2017
Merged
@CraigglesO
Copy link
Contributor

Dunno if this was intended but the meta data is the only thing that is stringified:

{
    "address": "007e101452124aae9e21f25d4e05f0411835ec75",
    "crypto": {
        "cipher": "aes-128-ctr",
        "cipherparams": {
            "iv": "7968ac68247490d108db682814eee446"
        },
        "ciphertext": "fd7fd2b862d8c6a38de5df34c9404bafa3c17a0f416ca07c8f4056ef32cbcb8f",
        "kdf": "pbkdf2",
        "kdfparams": {
            "c": 10240,
            "dklen": 32,
            "prf": "hmac-sha256",
            "salt": "e33c027fe579f359f86aff90e222b875060fcd8f6d7e83cfcd182c94d08243e7"
        },
        "mac": "6a8bf7e3dadd59d914f775f69907d23fc5ac86711ec6845c668998f4edfb29e2"
    },
    "id": "5394726e-06f4-9bb0-384d-170235296a6b",
    "meta": "{\"passwordHint\":\"E\",\"timestamp\":1490065563273}",
    "name": "CONNOR-DEV",
    "version": 3
}

@tomusdrw
Copy link
Collaborator Author

That's actually expected. We don't really parse meta at all in Parity anywhere, it's only used by UI.

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 22, 2017
@gavofyork gavofyork merged commit bb1bbeb into master Mar 23, 2017
@gavofyork gavofyork deleted the export-acc branch March 23, 2017 12:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@debris debris debris left review comments

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M6-rpcapi 📣 RPC API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tomusdrw @CraigglesO @debris @gavofyork @arkpar