EIP-8 #498
EIP-8 #498
Conversation
|
code looks fine; is it tested it with both types of clients? |
|
The EIP-8 changes to discovery are not easy to test unless you temporarily change the code to add some padding and additional elements to packets. |
| trace!(target:"net", "Received handshake auth to {:?}", self.connection.socket.peer_addr()); | ||
| if data.len() != AUTH_PACKET_SIZE { | ||
| fn read_auth(&mut self, secret: &Secret, data: &[u8]) -> Result<(), UtilError> { | ||
| trace!(target:"net", "Received handshake auth from {:?}", self.connection.socket.peer_addr()); |
There was a problem hiding this comment.
style for typical use of : would have a space after...
gavofyork
added
A8-looksgood 🦄
|
Tested against geth's RLPX_EIP8 |
cc @fjl
closes #349