Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

auto lint #5003

Merged
merged 2 commits into from
Mar 23, 2017
Merged

auto lint #5003

merged 2 commits into from
Mar 23, 2017

Conversation

CraigglesO
Copy link
Contributor

I have the habit of using double quotes. lol.

Autofix will remove all simple linting issues. Saves time.

@parity-cla-bot
Copy link

It looks like @CraigglesO signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@CraigglesO CraigglesO added the F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. label Mar 22, 2017
@NikVolf NikVolf added A0-pleasereview 🤓 Pull request needs code review. M7-ui and removed F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. labels Mar 22, 2017
js/package.json Outdated
@@ -48,6 +48,7 @@
"lint": "npm run lint:css && npm run lint:js",
"lint:cached": "npm run lint:css && npm run lint:js:cached",
"lint:css": "stylelint ./src/**/*.css",
"lint:fix": "./node_modules/.bin/eslint --fix 'src/**/*.spec.js' && ./node_modules/.bin/eslint --fix 'src/**/*.js'",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are running via npm run lint:fix tou can get rid of the ./node_modules/.bin/ prefix

@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 23, 2017
@jacogr jacogr merged commit e5c2b25 into master Mar 23, 2017
@jacogr jacogr deleted the auto-lint branch March 23, 2017 09:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants