Add CIDv0 RPC #5414
Add CIDv0 RPC #5414
Conversation
keorn
added
A0-pleasereview 🤓
rpc/src/v1/impls/light/parity.rs
Outdated
| @@ -342,4 +342,8 @@ impl Parity for ParityClient { | |||
| capability: Capability::Light, | |||
| }) | |||
| } | |||
|
|
|||
| fn ipfs_cid(&self, _content: Bytes) -> Result<String, Error> { | |||
| Err(errors::light_unimplemented(None)) | |||
There was a problem hiding this comment.
why not implement this for the light client as well?
| @@ -224,6 +225,14 @@ pub fn encryption_error<T: fmt::Debug>(error: T) -> Error { | |||
| } | |||
| } | |||
|
|
|||
| pub fn encoding_error<T: fmt::Debug>(error: T) -> Error { | |||
There was a problem hiding this comment.
_error suffix is not really necessary
There was a problem hiding this comment.
Should I change all the other functions in this module too?
There was a problem hiding this comment.
if so, worth a separate PR.
|
does "add it for the light client as well" really mean a verbatim duplicate of that function? suffice it to say i consider this rather bad practice. |
gavofyork
added
A5-grumble 🔥
|
It's mostly a symptom of the fact that the For now, we could toss |
|
@rphmeier Dont try to defend, that was just embarrassing... |
keorn
added
A0-pleasereview 🤓
gavofyork
added
A8-looksgood 🦄
No description provided.