This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
SecretStore: remove session on master node #5545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
added
A0-pleasereview 🤓
|
This fixes the hanging issue, thanks @svyatonik ! |
|
I think the diff covers lots of old changes, if its only |
keorn
added
A7-looksgoodcantmerge 🙄
rphmeier
reviewed
May 9, 2017
| @@ -1043,6 +1065,64 @@ impl ClusterClient for ClusterClientImpl { | |||
| } | |||
| } | |||
|
|
|||
| impl EncryptionSessionWrapper { | |||
| pub fn new(cluster: &Arc<ClusterData>, session_id: SessionId, session: Arc<EncryptionSession>) -> Arc<Self> { | |||
There was a problem hiding this comment.
typical style is to pass a Weak directly, this way it's more evident from the function signature that it's the caller's responsibility to keep the Arc alive.
svyatonik
added
A0-pleasereview 🤓
keorn
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #5439
Previously successfully completed session was only removed on 'slave' nodes