Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Check pending request on Node local transactions #5564

Merged
merged 4 commits into from
May 10, 2017

Conversation

ngotchac
Copy link
Contributor

@ngotchac ngotchac commented May 5, 2017

Closes #5358

Might also close #5349 (@jacogr might want to try, I couldn't reproduce it)

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels May 5, 2017
@jacogr jacogr added A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 9, 2017
@jacogr
Copy link
Contributor

jacogr commented May 9, 2017

Should fix the issues indeed since we are using parity_localTransactions now, which is the correct approach.

@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. labels May 10, 2017
@jacogr jacogr merged commit 8146cbd into master May 10, 2017
@jacogr jacogr deleted the ng-fix-pending-transactions branch May 10, 2017 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tx minimised should not use localSorage Tx display doesn't handle syncing very well
2 participants