This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Light friendly dapps #5634
Merged
Light friendly dapps #5634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-pleasereview 🤓
tomusdrw
reviewed
May 16, 2017
| @@ -60,7 +60,7 @@ fn should_return_503_when_syncing_but_should_make_the_calls() { | |||
|
|
|||
| // then | |||
| response.assert_status("HTTP/1.1 503 Service Unavailable"); | |||
| assert_eq!(registrar.calls.lock().len(), 4); | |||
| assert_eq!(registrar.calls.lock().len(), 2); | |||
There was a problem hiding this comment.
Can you update the test name as well?
There was a problem hiding this comment.
is it wrong now? "the calls" is pretty ambiguous: it's definitely making some calls, although not as many as before.
updater/src/updater.rs
Outdated
| .call_contract(BlockId::Latest, address, data) | ||
| fn call(&self, address: Address, data: Bytes) -> BoxFuture<Bytes, String> { | ||
| let res = (move || { | ||
| self.client.upgrade().ok_or_else(|| "Client not available".to_owned())? |
There was a problem hiding this comment.
I'd go with map instead of a closure.
There was a problem hiding this comment.
I used the closure because of the ? operator usage here, it seemed easier than doing an and_then
There was a problem hiding this comment.
IMHO would be cleaner with and_then:
futures::done(
self.client.upgrade()
.ok_or_else(|| "Client not available".to_owned())
.and_then(|client| client.call_contract(BlockId::Latest, address, data))
).boxed()
tomusdrw
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes the first steps towards a futures-based dapps server and activates it for the light client.